Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to workflow actions and upload to GHCR #2355

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

proffalken
Copy link
Contributor

What type of PR is this?

(REQUIRED)

  • feature

What this PR does / why we need it:

(REQUIRED)

Dockerhub have been restricting the number of times that an IP Address can download an image without paying for their monthly subscription. This PR uploads the image to Github Container Registry as well as DockerHub so we can truly distribute free software for free.

As part of this, I've also moved from the existing Bash commands to the "official" github action for building and pushing docker containers. This may mean it needs refinement to ensure that the tags work properly however it should also reduce the overhead of adding new architectures etc.

Which issue(s) this PR fixes:

(REQUIRED)

N/A - No github issue raised

Release Notes

(REQUIRED)

Containers are now available via GHCR

file: docker/api.Dockerfile
context: .
push: true
tags: api-${{ steps.meta.outputs.tags }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be ${{ inputs.tag }} like before?

@stale
Copy link

stale bot commented Jul 12, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 12, 2023
@stale stale bot closed this Jul 19, 2023
@hay-kot hay-kot reopened this Jul 19, 2023
@stale stale bot removed the stale label Jul 19, 2023
@hay-kot hay-kot self-assigned this Aug 20, 2023
@hay-kot hay-kot merged commit 71f1607 into mealie-recipes:mealie-next Sep 7, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants