1775 LDAP login and user creation fix #1777
Conversation
… search. And decoded the user_attributes from binary data to string
|
In #1487 the unit test has been changed from (see comment for an explanation): to The result should however not be false, since an array with an empty tuple is still a result since it is not an empty array, so the search was "successful" and an user is created. I will revert the asserts back in the unit test. |
Since an empty tuple is still a result, an user is created and the result should not be false.
|
FYI, I tried to run formatting to get this through, but the test is still failing. You can run both of these locally using the make file. |
|
This good to go now? |
|
|
||
| if not user: | ||
| user_bind = settings.LDAP_BIND_TEMPLATE.format(username) | ||
| user_bind = "cn={}, {}".format(username, settings.LDAP_BASE_DN) |
There was a problem hiding this comment.
This might break some LDAP setups, I suggest to leave the LDAP_BIND_TEMPLATE as it is.
For example on my server I need uid={},..., not cn={},....
There was a problem hiding this comment.
Did you get LDAP to work with v1? It seems that you are using FreeIPA.
Mine was working with v0.5, but v1 broke it.
I am trying
LDAP_BIND_TEMPLATE=uid={},cn=users,cn=accounts,dc=...,dc=...
LDAP_BASE_DN=cn=users,cn=accounts,dc=...,dc=...
There was a problem hiding this comment.
I'm not using FreeIPA, I use my own custom setup with OpenLDAP. But yes, it worked with v1.
|
@ERLKDev, I attempted to build with this but got: |
Sorry for the late response, have been quite busy last month and kind of forgot about it. Next week I have time to finish the PR. |
|
FYI in Python >= 3.10 you can use |
|
Merged in #2107 |
What type of PR is this?
What this PR does / why we need it:
This PR fixes two bugs in the code:
LDAP login not possible due to a programming error (wrong if statement)
Fullname and email adres in newly created users using LDAP had the binary values instead of the string values of the corresponding attributes
The full description of the bugs is available in #1775
Which issue(s) this PR fixes:
Fixes #1775