add/update tests

mealie-recipes · May 11, 2024 · 741c221 · 741c221
1 parent d9d7a48
commit 741c221
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 5 deletions.
diff --git a/frontend/composables/recipes/use-recipe-ingredients.test.ts b/frontend/composables/recipes/use-recipe-ingredients.test.ts
@@ -1,6 +1,6 @@
-import { describe, test, expect } from "vitest";
-import { parseIngredientText } from "./use-recipe-ingredients";
+import { describe, expect, test } from "vitest";
 import { RecipeIngredient } from "~/lib/api/types/recipe";
+import { parseIngredientText } from "./use-recipe-ingredients";
 
 describe(parseIngredientText.name, () => {
   const createRecipeIngredient = (overrides: Partial<RecipeIngredient>): RecipeIngredient => ({
@@ -34,6 +34,12 @@ describe(parseIngredientText.name, () => {
     expect(parseIngredientText(ingredient, false, 1, true)).contain("1 <sup>1</sup>").and.to.contain("<sub>2</sub>");
   });
 
+  test("ingredient text with fraction when unit is null", () => {
+    const ingredient = createRecipeIngredient({ quantity: 1.5, unit: undefined });
+
+    expect(parseIngredientText(ingredient, false, 1, true)).contain("1 <sup>1</sup>").and.to.contain("<sub>2</sub>");
+  });
+
   test("ingredient text with fraction no formatting", () => {
     const ingredient = createRecipeIngredient({ quantity: 1.5, unit: { fraction: true, id: "1", name: "cup" } });
     const result = parseIngredientText(ingredient, false, 1, false);

diff --git a/tests/integration_tests/user_recipe_tests/test_recipe_ingredients.py b/tests/integration_tests/user_recipe_tests/test_recipe_ingredients.py
@@ -2,8 +2,11 @@
 
 import pytest
 
-from mealie.schema.recipe.recipe_ingredient import IngredientFood, IngredientUnit, RecipeIngredient
-from tests.utils.factories import random_string
+from mealie.schema.recipe.recipe_ingredient import (
+    IngredientFood,
+    IngredientUnit,
+    RecipeIngredient,
+)
 
 
 @pytest.mark.parametrize(
@@ -19,6 +22,12 @@
 @pytest.mark.parametrize(
     ["unit", "expect_display_fraction", "expected_unit_singular_string", "expected_unit_plural_string"],
     [
+        [
+            None,
+            True,
+            "",
+            "",
+        ],
         [
             IngredientUnit(
                 id=uuid4(),
@@ -154,7 +163,7 @@ def test_ingredient_display(
     quantity: float | None,
     quantity_display_decimal: str,
     quantity_display_fraction: str,
-    unit: IngredientUnit,
+    unit: IngredientUnit | None,
     food: IngredientFood,
     note: str,
     use_food: bool,