Interpolate placeholders in tables #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marnen
commented
Mar 1, 2018
|
|
||
| then_ ~r/^the table data should (?<negation>not )?contain "(?<string>[^"]+)"$/, | ||
| fn %{table_data: table_data} = state, %{negation: negation, string: string} -> | ||
| contains = (for %{data: data} <- table_data, do: data) |> Enum.any?(&contains?(&1, string)) |
There was a problem hiding this comment.
This actually won't quite work. Will fix in a few minutes.
|
OK, I think this is ready to merge now. |
|
Looks like the red build was an error, not a failure. @meadsteve Can you restart that build job? I don't have the permissions to. |
meadsteve
approved these changes
Mar 5, 2018
|
Nice. Thanks for this 💯 I'll try and get it released later today. |
|
Great! |
|
@marnen now available as https://hex.pm/packages/white_bread/4.1.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<Placeholders> in tables within scenario outlines were being treated as literal text. I've fixed that.