Set file field of feature struct #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@leifg thanks for the PR it looks like it's trying to call a function in |
|
The problem with updating I will update |
leifg
force-pushed
the
patch-3
branch
2 times, most recently
from
2615672
to
a5db53a
Compare
|
OK so this was fun. I created 3 separated PRs, they should be merged in this order:
I will rebase after every merge to make sure we have no conflicting changes. |
|
This branch just needs a little cleanup after #92 and we're good 👍 |
the field `file` cabbage-ex/cabbage of was never set
|
Looks a lot cleaner now |
|
Awesome. Thanks for this. I should get a chance to package this as a release later today. |
|
As version 4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the field
filecabbage-ex/cabbage of was never set