Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update instructions for adding new macros #10513

Merged
merged 7 commits into from
Dec 23, 2021
Merged

Update instructions for adding new macros #10513

merged 7 commits into from
Dec 23, 2021

Commits on Nov 14, 2021

  1. Update instructions for adding new macros 

    I was looking at how to fix an incorrect spec link, and found some instructions made out-of-date by mdn/yari#4081. 

I have updated this section based on what I think is now the correct workflow with an updated example (based on the most-recent PR I found).
    @astearns
    astearns committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    6f6ecaa View commit details
    Browse the repository at this point in the history

  2. lint fixes

    @astearns
    astearns committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    00f18e3 View commit details
    Browse the repository at this point in the history

  3. macro/value distinction

    @astearns
    astearns committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    e5b6402 View commit details
    Browse the repository at this point in the history

  4. values, not strings

    @astearns
    astearns committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    c419c7c View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2021

  1. Perhaps do it this way?

    @hamishwillee
    hamishwillee committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    817bfae View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2021

  1. Update to: Making a change that depends on external content

    @hamishwillee
    hamishwillee committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    4aac803 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2021

  1. Fix md-lint errors, hopefully

    @wbamberg
    wbamberg committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    353b80a View commit details
    Browse the repository at this point in the history