Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add top-level await #7209

Merged
merged 7 commits into from
Nov 5, 2020
Merged

Add top-level await #7209

merged 7 commits into from
Nov 5, 2020

Conversation

saschanaz
Copy link
Contributor

A checklist to help your pull request get merged faster:

@github-actions github-actions bot added the data:js 📟 Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript label Oct 31, 2020
@github-actions github-actions bot added the data:browsers 🌍 Data about browsers (versions, release dates, etc). This data is used for validation. label Oct 31, 2020
@queengooborg
Copy link
Collaborator

Looking good to me! Just a little nitpick to keep the scope of the PR small, can we separate the browser file changes into its own separate PR?

@ddbeck ddbeck removed the data:browsers 🌍 Data about browsers (versions, release dates, etc). This data is used for validation. label Nov 5, 2020
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor issues in line comments, but otherwise good. Thank you, @saschanaz!

javascript/operators/await.json Outdated Show resolved Hide resolved
javascript/operators/await.json Outdated Show resolved Hide resolved
saschanaz and others added 2 commits November 5, 2020 18:22
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you! 🎉

@ddbeck ddbeck merged commit 80e0b06 into mdn:master Nov 5, 2020
@saschanaz saschanaz deleted the top-level-await branch November 5, 2020 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:js 📟 Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants