Skip to content
This repository has been archived by the owner on Oct 27, 2021. It is now read-only.

[WIP] server: initial cut of vgo-aware type loader #26

Closed
wants to merge 4 commits into from

Conversation

myitcv
Copy link

@myitcv myitcv commented Apr 11, 2018

DO NOT MERGE

Requires vgo as of https://go-review.googlesource.com/c/vgo/+/105855

Note: this is based atop #23

The current diff for this PR can be see here:

myitcv/gocode@import_name_qualify...myitcv:vgo_loader

Non vgo-mode still does _not_ use the build cache, hence all packages
need to have been "go install"-ed
@OneOfOne
Copy link

@myitcv I have forked this package and maintaining it on https://github.com/OneOfOne/gocode for now and with this PR, and I'm using it locally as well.

You are more than welcome to rebase on my fork, or if you update this PR yo ucan tag me and I'll rebase.

I plain on maintaining my fork until mdempsky gets back to this repo or go-langserver implements proper code completion without gocode.

@mdempsky
Copy link
Owner

Thanks for working on this. I haven't really kept up with vgo progress, so maybe you can help bring me up to speed on two questions:

  1. Why does gocode need to know about vgo?

  2. Assuming we do need a vgo-aware go/importer.Importer implementation, shouldn't that implementation live within the x/vgo or x/tools repo? I'm assuming we'd want gotype, guru, etc. to work with vgo too. Or is there something gocode-specific about this importer?

@rsc
Copy link

rsc commented Apr 27, 2018

@myitcv, could you please stop sending these pull requests to projects, even marked DO NOT MERGE. They're confusing people.

@myitcv
Copy link
Author

myitcv commented Apr 27, 2018

@rsc apologies. I'll close this.

@myitcv myitcv closed this Apr 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants