Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix messed up CMake targets for NUCLEO_H745ZI_Q #363

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

multiplemonomials
Copy link
Collaborator

Summary of changes

The CMake build files for NUCLEO_H745ZI_Q were quite messed up -- it never added the subdirectory, and some of the target names had typos so it couldn't actually build properly. This fixes the buildfile issues and condenses down the CMake targets to remove duplicated code.

Impact of changes

Migration actions required

Documentation


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[X] Tests / results supplied as part of this PR

Built locally for NUCLEO_H745ZI_Q_CM7 and it builds OK!


@multiplemonomials multiplemonomials merged commit d5278aa into master Sep 25, 2024
10 checks passed
@multiplemonomials multiplemonomials deleted the bugfix/nucleo-h745zi-q-targets-messed-up branch September 25, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants