Fix off-by-1 error in memap's symbol-contained-in-memory-bank check, clean up some linker script stuff #362
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
I noticed that for targets that had stack fill up until the end of a memory bank, the new memap version was doing some weird stuff:
*fill*
that did itTurns out there was an off by 1 error in the check for whether a symbol went outside a memory bank, and an issue with the regex that detected the names of input sections.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Verified that we aren't seeing the memap warning after this issue.