Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix off-by-1 error in memap's symbol-contained-in-memory-bank check, clean up some linker script stuff #362

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

multiplemonomials
Copy link
Collaborator

Summary of changes

I noticed that for targets that had stack fill up until the end of a memory bank, the new memap version was doing some weird stuff:

  • It would print a warning about the symbol going outside of the memory bank,
  • And, that warning would have the wrong name, it would call out a previous symbol name rather than saying it was *fill* that did it

Turns out there was an off by 1 error in the check for whether a symbol went outside a memory bank, and an issue with the regex that detected the names of input sections.

Impact of changes

Migration actions required

Documentation


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[X] Tests / results supplied as part of this PR

Verified that we aren't seeing the memap warning after this issue.


@multiplemonomials multiplemonomials merged commit 798dd6b into master Sep 25, 2024
10 checks passed
@multiplemonomials multiplemonomials deleted the bugfix/memap-contains-off-by-1 branch September 25, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants