Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruff formatting + checks #66

Merged
merged 6 commits into from
Sep 26, 2024
Merged

Ruff formatting + checks #66

merged 6 commits into from
Sep 26, 2024

Conversation

dbrakenhoff
Copy link
Collaborator

Address most ruff issues (besides documentation, see pyproject.toml for ignore list)

Add python 3.12 to CI, remove Python 3.8

Hopefully fixes numpy 2.0 issues, as well.

- add ruff settings to pyproject.toml
- fix all problems (some are ignored, see pyproject for those)
- add ruff check to CI
- remove python 3.8 and add 3.12
@dbrakenhoff dbrakenhoff self-assigned this Sep 25, 2024
Copy link
Owner

@mbakker7 mbakker7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Should we also drop Python 3.10? Is the lowest required numpy version correct?

@dbrakenhoff
Copy link
Collaborator Author

Python 3.10 will be dropped by numpy in Apr 2025, so we should keep that one in for now I think.
I did remove all the minimum dependencies, those are fairly old, so doesnt make much sense to keep them in.

@dbrakenhoff dbrakenhoff merged commit c1e2121 into dev Sep 26, 2024
5 of 6 checks passed
@dbrakenhoff dbrakenhoff deleted the ruff branch September 26, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants