Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serial connection support for macOS #372

Merged
merged 7 commits into from
Apr 26, 2018
Merged

Serial connection support for macOS #372

merged 7 commits into from
Apr 26, 2018

Conversation

julianoes
Copy link
Collaborator

It recently came up on Slack that it would be good to have support for the serial connection on macOS.

@hamishwillee
Copy link
Collaborator

@julianoes This concerns me - I was not aware that any of our APIs were "platform specific". If we don't support an API on a particular platform then that should be part of the documentation.

So does this work on Windows? Are there any other APIs that we know only work on Linux, Windows or Mac?

@JonasVautherin
Copy link
Collaborator

@hamishwillee: For what I understand from the code, the serial connection is now supported on Linux and macOS, and not on Windows.

@hamishwillee
Copy link
Collaborator

@hamishwillee: For what I understand from the code, the serial connection is now supported on Linux and macOS, and not on Windows.

Thanks. Then we should probably add a warning to DroneCore::add_any_connection() and add_serial_connection() docs. Something like

@warning This method is not supported on Windows (it is supported on Linux and macOS).

I am making the assumption that everything else works everywhere.

@JonasVautherin
Copy link
Collaborator

I am making the assumption that everything else works everywhere.

I wouldn't know 😀.

@julianoes
Copy link
Collaborator Author

@hamishwillee you're right.
Let's add that comment about Windows.

UDP and TCP connections are supported on all 3 operating systems.

@julianoes julianoes merged commit e9c777b into develop Apr 26, 2018
@julianoes julianoes deleted the macos-serial branch April 26, 2018 13:57
julianoes added a commit that referenced this pull request Sep 30, 2018
This fixes a bug introduced in #372.

By adding macOS support for serial, I had accidentally removed setting
the baudrate for Linux.
hdiethelm pushed a commit to hdiethelm/DronecodeSDK that referenced this pull request Nov 4, 2018
This fixes a bug introduced in mavlink#372.

By adding macOS support for serial, I had accidentally removed setting
the baudrate for Linux.
rt-2pm2 pushed a commit to rt-2pm2/DronecodeSDK that referenced this pull request Nov 27, 2018
Serial connection support for macOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants