Make use of smart pointers and references #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 13, 2018 12:05
Replace `Device *PluginImplBase::parent` => `Device &PluginImplBase::parent`. And replaces everywhere as required.
Replaced wherever applicabale.
Smart pointers provide automatic resource management. In other words, they implement "Resource Acquisition Is Initialialization programming idiom". The main goal of this idiom is to ensure that resource acquisition occurs at the same time that the object is initialized, so that all resources for the object are created and made ready in one line of code. `std::unique_ptr` is a smart pointer that owns and manages another object through a pointer and disposes of that object when the unique_ptr goes out of scope. Ref 1: https://docs.microsoft.com/en-us/cpp/cpp/smart-pointers-modern-cpp Ref 2: http://en.cppreference.com/w/cpp/memory/unique_ptr
|
I think, we should use |
|
|
In `CMakeLists.txt`, include directory for example.h is added.
core/dronecore_impl.cpp
Outdated
| @@ -330,7 +330,7 @@ void DroneCoreImpl::create_device_if_not_existing(const uint8_t system_id) | |||
| } | |||
|
|
|||
| // Create both lists in parallel | |||
There was a problem hiding this comment.
Actually, this comment makes no sense now :) I shall remove it in next commit.
This replaces raw pointers used in connections and devices by smart pointers. This avoids, freeing them in destructor and also makes code clean and readable.
|
Executed |
Updates all the plugin API description about passing device object, instead of pointer to it.
julianoes
approved these changes
Mar 13, 2018
hamishwillee
approved these changes
Mar 14, 2018
There was a problem hiding this comment.
Looks good to me! Docs changes make sense. I think you caught the required "source based" changes, but I'll check more thoroughly after this is merged. Created mavlink/MAVSDK-docs#106 to track required docs changes.
|
@JonasVautherin when is a good time to merge this? 😄 |
|
I'm finishing my review now, I will merge it in a few minutes. Sorry for the delay =/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces raw pointers by smart pointers and references as applicable.
We have to use references when we can, and pointers when we have to.
Smart pointers provide automatic resource management. In other words, they implement Resource Acquisition Is Initialization programming idiom. The main goal of this idiom is to ensure that resource acquisition occurs at the same time that the object is initialized, so that all resources for the object are created and made ready in one line of code.
std::unique_ptris a smart pointer that owns and manages another object through a pointer and disposes of that object when the unique_ptr goes out of scope.std::shared_ptris a smart pointer that retains shared ownership of an object through a pointer. Several shared_ptr objects may own the same object. The object is destroyed and its memory deallocated when either of the following happens:shared_ptrowning the object is destroyed;shared_ptrowning the object is assigned another pointer viaoperator=orreset().References:
Fixes #314