build_system: build statically again for Mac #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasVautherin
approved these changes
Feb 18, 2018
core/CMakeLists.txt
Outdated
| @@ -13,21 +13,21 @@ else() | |||
| endif() | |||
|
|
|||
| # We need tinyxml2 for the camera definition parsing. | |||
| if(IOS OR APPLE) | |||
| if(APPLE) | |||
| # We install the tinyxml2 library manually for macOS and iOS. | |||
| # The install is commented out as long as we build statically. | |||
There was a problem hiding this comment.
Actually this comment is obsolete now, I guess it should be removed.
Also note that we never built tinyxml2 as a static library, I believe (and we'll need that for iOS). It requires BUILD_STATIC_LIBS to be set, which I guess we don't want to set in the whole scope of core/CMakeLists.txt. So we will need more than add_subdirectory for building tinyxml2.
I am planning to work a bit more on the build system, but after I get the prototype running on iOS :-).
There was a problem hiding this comment.
Thanks, removed the comment.
This is just an interim fix in the meantime.
julianoes
force-pushed
the
fix-mac-linking
branch
from
58bfa09
to
dc19840
Compare
rt-2pm2
pushed a commit
to rt-2pm2/DronecodeSDK
that referenced
this pull request
Nov 27, 2018
* build_system: build statically again for Mac This is just an interim fix in the meantime.
JonasVautherin
pushed a commit
that referenced
this pull request
Aug 15, 2023
action: add unsupported result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just an interim fix in the meantime.
Should fix #233.