Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stop in mavsdk_server #1535

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Fix stop in mavsdk_server #1535

merged 1 commit into from
Sep 9, 2021

Conversation

JonasVautherin
Copy link
Collaborator

Now that mavsdk_server.run() blocks until a system is discovered, mavsdk_server.stop() must cancel it.

@JonasVautherin JonasVautherin force-pushed the fix-stop-mavsdk-server branch 7 times, most recently from bbe66b5 to 982202a Compare September 9, 2021 05:00
@julianoes julianoes marked this pull request as ready for review September 9, 2021 08:04
Copy link
Collaborator

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks alright.

@JonasVautherin
Copy link
Collaborator Author

Tested to work with MAVSDK-Swift and MAVSDK-Python 🎉

@JonasVautherin JonasVautherin merged commit 2780542 into main Sep 9, 2021
@JonasVautherin JonasVautherin deleted the fix-stop-mavsdk-server branch September 9, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants