added vtol state implementation (follow up) #1521
Conversation
|
The proto change was already done but this we might be able to use, thank you! |
|
Yes, I saw that @rligocki was first on the proto but for the implementation I don't see a pull request. Any chance to merge his proto and my implementation? |
| /** | ||
| * @brief VTOL State enumeration | ||
| */ | ||
| enum class VtolState { |
There was a problem hiding this comment.
I used the same naming scheme like in the other enums although I would personally prefer using more intuitive names than Mc and Fw
There was a problem hiding this comment.
Yes the enums are just based on MAVLink definitions https://mavlink.io/en/messages/common.html#MAV_VTOL_STATE
|
Pull request should be already done on Proto side. I think It was today when @julianoes merged it. |
Let's try. |
julianoes
force-pushed
the
vtol-state
branch
from
21cf244
to
cbbd8bf
Compare
|
I've force-pushed this with the latest changes from mavlink/MAVSDK-Proto#251. |
julianoes
changed the title
|
Looks good, should work with |
vtol state implementation in the telemetry plugin