Examples cleanup #1449

julianoes · 2021-05-29T09:38:34Z

Taking a pass through all examples.

This includes:

Naming improvements of the examples
Replacing std::endl with \n (cause flushing is not always required, in general)
Removing log output colors (I want to focus on simple code that's easy to read, rather than pretty output, and in the future we might make use of std::fmt anyway for that.)
Replace most custom helpers with more boilerplate but easier to grasp repetitive code.
Clean up file comments (remove filename in comment and remove authors, as this tends to be always out of date and wrong)

- Make sure all examples are built. - Use consistent naming for directory, project, executable. - Check dependencies. - Use target_compile_options instead of add_definitions.

julianoes added the enhancement label May 29, 2021

julianoes requested a review from JonasVautherin May 29, 2021 09:38

julianoes force-pushed the pr-example-cleanup branch 2 times, most recently from 28aed30 to ed15ade Compare May 29, 2021 12:57

julianoes force-pushed the pr-example-cleanup branch from ed15ade to c325228 Compare July 24, 2021 16:26

julianoes added 7 commits July 24, 2021 19:43

examples: clean up cmake files

f1a4abc

- Make sure all examples are built. - Use consistent naming for directory, project, executable. - Check dependencies. - Use target_compile_options instead of add_definitions.

follow_me: use unique_ptr, not raw pointer

deadcdc

examples: shared_ptr around promise not required

1cbfde3

examples: pass through follow_me example

bebfe78

examples: pass through fly_mission example

81c2cad

examples: pass through gimbal example

fd6cad0

examples: pass through fly_qgc_mission example

9eff531

julianoes force-pushed the pr-example-cleanup branch from c325228 to 9eff531 Compare July 24, 2021 17:43

julianoes added 17 commits July 29, 2021 13:36

examples: pass through battery example

2af7971

examples: pass through calibration example

3aa1958

examples: pass through fly_multiple_drones example

ce97afa

examples: pass through fly_qgc_mission example

2f3728a

examples: pass through ftp_client example

006f9e9

examples: pass through ftp_server example

e3bffe9

examples: pass through geofence_inclusion example

d5b2685

examples: pass through gimbal_device_tester example

e80ed4e

examples: pass through manual_control example

b239326

examples: pass through mavshell example

a4c7609

examples: pass through multiple_drones example

e64cd55

examples: pass through off example

2857506

examples: pass through set_actuator example

8702dee

examples: pass through takeoff_and_land example

4ba7d0a

examples: pass through transition_vtol_fixed_wing example

79d1126

examples: pass through transpoder example

9810807

examples: pass through tune example

25be822

julianoes added 2 commits July 29, 2021 13:42

examples: rename transition_vtol_fixed_wing to vtol_transition

3c4d19b

examples: rename offboard_velocity to offboard

d8b531b

julianoes marked this pull request as ready for review July 29, 2021 11:49

julianoes merged commit 5c03390 into main Jul 30, 2021

julianoes deleted the pr-example-cleanup branch July 30, 2021 08:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Examples cleanup #1449

Examples cleanup #1449

julianoes commented May 29, 2021 •

edited

Loading

Examples cleanup #1449

Examples cleanup #1449

Conversation

julianoes commented May 29, 2021 • edited Loading

julianoes commented May 29, 2021 •

edited

Loading