Fix jsoncpp Werror with NDK r22b #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could also just make sure we don't try to build with |
|
Yeah... but I don't think we set it for downstream at all, so that is something to do for each dependency separately. In this case, it seemed to me that the default for jsoncpp was without werror, but for some reason it was failing here for Android. I did not look further into it because I think we should update to jsoncpp 1.9.4 as soon as possible, so this PR was just to not fail in the meantime. |
julianoes
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JsonCpp fails to build on Android with NDK r22b. This is not a problem for the CI yet, but it will come soon (the CI is on r21). This fixes it.
I am also looking into updating JsonCpp (see here), which may allow us to remove all the patches. But that may take longer, so I fixed this issue first.