Added transponder plugin #1390

DoppleGangster · 2021-03-31T16:16:55Z

JonasVautherin

Good start! Do you have a way to test that the conversions are correct? Like do you have a mavlink component that emits ADS-B messages?

src/plugins/transponder/include/plugins/transponder/transponder.h

src/plugins/transponder/transponder_impl.cpp

JonasVautherin · 2021-03-31T17:03:08Z

One more thing: you need to fix the style, we have a script for that: ./tools/fix_style . should do it 👍

Co-authored-by: Jonas Vautherin <jonas.vautherin@protonmail.ch>

DoppleGangster · 2021-03-31T17:14:15Z

I thought I had already run the style script. I'll make sure to run it. I have an ADSB module ordered and it suppose to be delivered today.

DoppleGangster · 2021-03-31T17:20:53Z

Style should be correct now.

JonasVautherin

Somehow all the conversions got lost in the process (i.e. all my suggestions). Did you revert them? 🤔

DoppleGangster · 2021-03-31T21:48:13Z

I uploaded the files with the style changes. Not sure if that removes comments?

DoppleGangster · 2021-03-31T21:53:24Z

I think I know what happened. I'll go through and reimplement your recommendations tomorrow.
Sorry about that.

JonasVautherin · 2021-03-31T21:55:04Z

Also you get some unrelated CI issues, please rebase once #1392 is merged and that should solve them 👍

DoppleGangster · 2021-04-01T09:53:22Z

@JonasVautherin: I've re-implemented your commits that were lost.

JonasVautherin · 2021-04-01T11:13:58Z

Starting to look good! Should we now wait until you can actually test it, and then move forward to merge it?

DoppleGangster · 2021-04-01T12:25:43Z

Sounds good to me. My expected receive date has gone to pending so most likely won't have the test results until sometime next week. Thanks for you help with this!

JonasVautherin · 2021-04-02T14:45:19Z

src/plugins/transponder/transponder_impl.cpp

+    _parent->unregister_statustext_handler(this);
+    _parent->unregister_param_changed_handler(this);


Why are those needed? They are not registered in the init, are they? 🤔

Ahh yeah you're right. I'll remove them. I was using the telemetry_imp.cpp as a guide and might have gotten carried away with what I was bring over. I've received the sensor however my test code seems to have issues. My subscription that I create should output text at 1 Hz however I never get any output from the function.

Is there another tie in somewhere that I need to get mavsdk to register my subscription?

Created Example

DoppleGangster · 2021-04-04T13:29:32Z

@JonasVautherin: If I register for the subscription updates in the test program for the transponder API should I expect to get the values reported even if the transponder if not communicating? I get no errors when I set the update rate and subscription but it does not appear that the callback is ever executed.

JonasVautherin · 2021-04-04T21:49:06Z

If I register for the subscription updates in the test program for the transponder API should I expect to get the values reported even if the transponder if not communicating?

When you subscribe, you will receive an update everytime the MAVLink message is sent. If your transponder does not send the MAVLink message, then nothing will happen. I'm expecting that the receiver is onboard the drone, receives ADS-B data and sends them as MAVLink messages on the sysid of the drone. Is that correct?

DoppleGangster · 2021-04-04T23:17:44Z

The receiver is onboard and I configured according to the PX4 Air Traffic Setup. I'm assuming this would be the same configuration to be able to access the MAVLINK messages for the ADS-B. The only difference in hardware is I'm using the NXP-FMU with a PingRX versus the mRO Pixhawk mentioned in the page.

DoppleGangster · 2021-04-05T12:58:07Z

@JonasVautherin : It does not appear that I have the ability to change the ADS-B module to use the drones sysid. Is there a way to have MAVSDK report messages of a certain type regardless of the sysid or do I need to find a way to grab the broadcast messages from the telemetry port that is communicating with offboard program?

TSC21 · 2021-04-05T13:04:40Z

@DoppleGangster did you check if the firmware at runtime enters this loop: https://github.com/PX4/PX4-Autopilot/blob/master/src/modules/mavlink/streams/ADSB_VEHICLE.hpp#L69. Have you tried accessing the nsh shell (can be done through the MAVLink shell in QGC) and type listener transponder_report? If it states something like never published then something is wrong in your setup.
Before debugging MAVSDK, the first thing you need to do is making sure you actually have the transponder data being generated and propagated in PX4 and also being streamed through MAVLink.

DoppleGangster · 2021-04-05T13:14:57Z

@TSC21 thanks for the comment. I confirmed that the data was never published. I've corrected the setup and now I am getting data from the transponder over MAVSDK.

@JonasVautherin and @TSC21 thank you both for your help with debugging this.

DoppleGangster · 2021-04-05T17:46:48Z

The plugin seems to be fully operation from my testing. Assuming no more changes are requested should be ready to merge with the proto fork update I would think?

TSC21 · 2021-04-05T18:01:21Z

The plugin seems to be fully operation from my testing. Assuming no more changes are requested should be ready to merge with the proto fork update I would think?

@DoppleGangster for both being ready for merge, you need to first squash the commits.

JonasVautherin

Good to read that it works!

I merged the MAVSDK-Proto PR. @DoppleGangster now you need to update the proto submodule such that it points to main on mavsdk-proto, and fix the style in this PR. Then we can merge it 👍 🚀

DoppleGangster · 2021-04-06T09:53:00Z

Proto module update is in and style updated. Thanks again!

Add transponder plugin

faadb15

JonasVautherin requested changes Mar 31, 2021

View reviewed changes

DoppleGangster and others added 4 commits March 31, 2021 13:07

Update src/plugins/transponder/transponder_impl.cpp

5f9e9bc

Co-authored-by: Jonas Vautherin <jonas.vautherin@protonmail.ch>

Update src/plugins/transponder/transponder_impl.cpp

19c17f6

Co-authored-by: Jonas Vautherin <jonas.vautherin@protonmail.ch>

Update src/plugins/transponder/transponder_impl.cpp

7ca61c0

Co-authored-by: Jonas Vautherin <jonas.vautherin@protonmail.ch>

Update src/plugins/transponder/transponder_impl.cpp

3bd3a0b

Co-authored-by: Jonas Vautherin <jonas.vautherin@protonmail.ch>

DoppleGangster added 3 commits March 31, 2021 13:18

Style Fixed.

326e1c4

Style Fixed.

3a4beae

Style Fixed.

ad321eb

Regenerated with comments for emitter type.

3191ca6

JonasVautherin requested changes Mar 31, 2021

View reviewed changes

Re-Added lost commits.

2c03f1b

Added registration of message handler

f216bdd

JonasVautherin reviewed Apr 2, 2021

View reviewed changes

DoppleGangster and others added 4 commits April 2, 2021 11:41

Removed unused unregisters from deinit()

57aa50e

Add example

b9f0283

Add files via upload

54776f4

Update transponder.cpp

79e82d4

Update transponder.cpp

5bc923a

JonasVautherin requested changes Apr 5, 2021

View reviewed changes

julianoes added the feature label Apr 6, 2021

DoppleGangster added 2 commits April 6, 2021 05:24

Proto submodule updated to main branch

d18c5a5

Style fixed.

eeffcc1

JonasVautherin approved these changes Apr 6, 2021

View reviewed changes

JonasVautherin merged commit 3770ef6 into mavlink:main Apr 6, 2021

TSC21 mentioned this pull request Apr 7, 2021

Feature: add support for ADS-B data #33

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added transponder plugin #1390

Added transponder plugin #1390

DoppleGangster commented Mar 31, 2021 •

edited by JonasVautherin

Loading

JonasVautherin left a comment

JonasVautherin commented Mar 31, 2021

DoppleGangster commented Mar 31, 2021

DoppleGangster commented Mar 31, 2021

JonasVautherin left a comment

DoppleGangster commented Mar 31, 2021

DoppleGangster commented Mar 31, 2021

JonasVautherin commented Mar 31, 2021

DoppleGangster commented Apr 1, 2021

JonasVautherin commented Apr 1, 2021

DoppleGangster commented Apr 1, 2021

JonasVautherin Apr 2, 2021

DoppleGangster Apr 2, 2021

DoppleGangster commented Apr 4, 2021

JonasVautherin commented Apr 4, 2021

DoppleGangster commented Apr 4, 2021

DoppleGangster commented Apr 5, 2021

TSC21 commented Apr 5, 2021 •

edited

Loading

DoppleGangster commented Apr 5, 2021

DoppleGangster commented Apr 5, 2021

TSC21 commented Apr 5, 2021

JonasVautherin left a comment

DoppleGangster commented Apr 6, 2021

		_parent->unregister_statustext_handler(this);
		_parent->unregister_param_changed_handler(this);

Added transponder plugin #1390

Added transponder plugin #1390

Conversation

DoppleGangster commented Mar 31, 2021 • edited by JonasVautherin Loading

JonasVautherin left a comment

Choose a reason for hiding this comment

JonasVautherin commented Mar 31, 2021

DoppleGangster commented Mar 31, 2021

DoppleGangster commented Mar 31, 2021

JonasVautherin left a comment

Choose a reason for hiding this comment

DoppleGangster commented Mar 31, 2021

DoppleGangster commented Mar 31, 2021

JonasVautherin commented Mar 31, 2021

DoppleGangster commented Apr 1, 2021

JonasVautherin commented Apr 1, 2021

DoppleGangster commented Apr 1, 2021

JonasVautherin Apr 2, 2021

Choose a reason for hiding this comment

DoppleGangster Apr 2, 2021

Choose a reason for hiding this comment

DoppleGangster commented Apr 4, 2021

JonasVautherin commented Apr 4, 2021

DoppleGangster commented Apr 4, 2021

DoppleGangster commented Apr 5, 2021

TSC21 commented Apr 5, 2021 • edited Loading

DoppleGangster commented Apr 5, 2021

DoppleGangster commented Apr 5, 2021

TSC21 commented Apr 5, 2021

JonasVautherin left a comment

Choose a reason for hiding this comment

DoppleGangster commented Apr 6, 2021

DoppleGangster commented Mar 31, 2021 •

edited by JonasVautherin

Loading

TSC21 commented Apr 5, 2021 •

edited

Loading