Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mission: move QGC plan import from mission to mission_raw #1343

Merged
merged 2 commits into from
Mar 5, 2021
Merged

mission: move QGC plan import from mission to mission_raw #1343

merged 2 commits into from
Mar 5, 2021

Commits on Mar 5, 2021

  1. mission: move QGC plan import from mission to mission_raw 

    This moves the method to import QGroundControl .plan JSON mission files
from the mission plugin to the mission_raw plugin.

The reasoning is as follows:
The imported missions did not really fit the Mission API, and I guess
that the mission progress was often wrong. When the missions were
imported into mission, many items/commands were unsupported and dropped
with a warning. Such a warning is not visible in the language wrappers
and could lead to surprises. The documentation said that the method
would fail if any unsupported item was being imported, however, that
was not true anymore in code.

Therefore, in my opinion, it makes a lot more sense to implement the
import in mission_raw where all/any mission items and commands can be
imported. It's should be more complete, without surprises, and
therefore safer to use.

And in later steps we can also add geofence and rally items to this API.

This PR contains the proto change and the implementation in code. It
also slightly improves the parsing by moving it to a separate file and
adding a bit more unit test coverage.
    @julianoes
    julianoes committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    efd50ea View commit details
    Browse the repository at this point in the history

  2. examples: use new MissionRaw import

    @julianoes
    julianoes committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    42c4ed1 View commit details
    Browse the repository at this point in the history