Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cam mode warnings #1247

Merged
merged 4 commits into from
Oct 29, 2020
Merged

Fix cam mode warnings #1247

merged 4 commits into from
Oct 29, 2020

Conversation

JonasVautherin
Copy link
Collaborator

  • If camera definition defines CAM_MODE, save it with the right type when coming from CAMERA_SETTINGS
  • Pass shared_ptr by value instead of reference, so that it behaves like one would expect
  • Send correct result in the InProgress callback, so that it can properly be ignored (otherwise the promise is resolved twice when it happens)

julianoes
julianoes approved these changes Oct 29, 2020
View reviewed changes
Copy link
Collaborator

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@JonasVautherin
Copy link
Collaborator Author

ActionHover is failing in integration tests, but I think it is unrelated.

@julianoes
Copy link
Collaborator

Yes, it has been failing before.

@julianoes julianoes merged commit fddbd95 into develop Oct 29, 2020
@julianoes julianoes deleted the fix-cam-mode-warnings branch October 29, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianoes julianoes julianoes approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonasVautherin @julianoes