Move from C++11 to C++17 (second try) #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Almost there, just missing iOS. I see a lot of errors of the sort: "only available on iOS 11 or newer": |
JonasVautherin
previously approved these changes
Sep 25, 2020
julianoes
force-pushed
the
pr-move-to-cpp17-again
branch
from
0128eac
to
aa949d8
Compare
This is an intermediate step in order to move to C++17.
We can't use it because the constructor is private. Also see: https://abseil.io/tips/134.
julianoes
force-pushed
the
pr-move-to-cpp17-again
branch
from
82539af
to
ad59b6b
Compare
|
Rebased on top of |
JonasVautherin
approved these changes
Nov 23, 2020
| @@ -238,25 +222,25 @@ class MAVLinkParameters { | |||
|
|
|||
| bool set_as_same_type(const std::string& value_str) | |||
| { | |||
| if (_value.is<uint8_t>()) { | |||
| if (std::get_if<uint8_t>(&_value)) { | |||
There was a problem hiding this comment.
I suppose _value.is does not work with a variant, hence this change?
There was a problem hiding this comment.
I think so. There is also std::get which throws instead: https://en.cppreference.com/w/cpp/utility/variant/get
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous try was #884.