Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GetAllParams function #1191

Merged
merged 3 commits into from
Sep 30, 2020
Merged

Add GetAllParams function #1191

merged 3 commits into from
Sep 30, 2020

Conversation

helo9
Copy link
Contributor

@helo9 helo9 commented Sep 18, 2020

This PRs aim to introduce a GetAllParams function, as already started in MAVSDK-Proto PR#175.
The only testing I have done so far is the integration test I have added. Therefore I keep it a draft for now.

JonasVautherin
JonasVautherin requested changes Sep 21, 2020
View reviewed changes
Copy link
Collaborator

@JonasVautherin JonasVautherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me! The docs CI test is failing, with:

Compound mavsdk::Param::IntParam is not documented.
Compound mavsdk::Param::AllParams is not documented.
Compound mavsdk::Param::FloatParam is not documented.

I think that's because the messages miss the documentation here, here and here

src/plugins/param/param_impl.cpp Outdated Show resolved Hide resolved
@helo9 helo9 marked this pull request as ready for review September 26, 2020 16:41
@JonasVautherin JonasVautherin mentioned this pull request Sep 28, 2020
Merged
helo9 and others added 2 commits September 30, 2020 20:15
@helo9
Add GetAllParams function
4200746
@helo9
Update src/plugins/param/param_impl.cpp
9dd85a3 
Co-authored-by: Jonas Vautherin <jonas.vautherin@protonmail.ch>
JonasVautherin
JonasVautherin approved these changes Sep 30, 2020
View reviewed changes
Copy link
Collaborator

@JonasVautherin JonasVautherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@JonasVautherin JonasVautherin merged commit 5c80b44 into mavlink:develop Sep 30, 2020
@helo9 helo9 deleted the allparams branch October 1, 2020 06:15
@helo9
Copy link
Contributor Author

helo9 commented Oct 1, 2020

Thanks a lot!

Thank you for updating the protos 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasVautherin JonasVautherin JonasVautherin approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@helo9 @JonasVautherin @julianoes