travis: add release build #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is enough to just build a PR commit, the branch doesn't need building as well.
It turns out when compiling with Visual Studio this means it is cmake "multi-configuration" and therefore we need to use `--config Debug` instead of `-DCMAKE_BUILD_TYPE="Debug"`.
|
Note to self: I give up. Need to debug this on a Windows machine. |
Apparently /MD means "use the multithread-specific and DLL-specific version of the run-time library". Also this should fix the release build somehow.
|
Is this ready to get reviewed? |
Yes please. |
|
@julianoes can you update your branch?, I'll make sure to merge! |
Closed
dlech
pushed a commit
to dlech/MAVSDK
that referenced
this pull request
Jan 14, 2022
Initial MoCap service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run release builds in travis and fix compile errors for release builds.
Closes #92.