Fix #8: Allow internal links #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@matthewhchan thank you for your awesome plugin!
This PR allows using internal links (e.g. [[test]]) in the plugin. As I needed the feature myself and saw that there also was an open issue asking for it, I decided to implement it.
While this was possible using the Obsidian URI-scheme
obsidian://open?file=$1, I believe this is not very user friendly, as it is not obvious and you have to URI encode the destination file path. Now you can just enter an internal link as target.Once a match is detected, we check if the target is an internal link, and if so we open the file directly in Obsidian. Otherwise we open the external link.
Note: I also had to update some dependencies, because I was getting an error with codemirror types. I suggest commiting the lockfile to the repo.