New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a missing Future->done #974

Merged

richvdh merged 1 commit into develop from rav/fix_upgrade_test

Oct 16, 2020

+1 −0

Member

richvdh commented Oct 15, 2020

Seems to have broken in #972. What I don't understand is why it is still working in the CI.


          Fix a missing Future->done

8d4f4d9

Seems to have broken in #972

richvdh requested a review from a team

October 15, 2020 23:45

Member Author

richvdh commented Oct 15, 2020

oh, it turns out this is allowed in Future 0.45: https://metacpan.org/source/PEVANS/Future-0.45/Changes#L5. If we're dropping support for earlier versions we need to note this in cpanfile.

erikjohnston approved these changes

View reviewed changes

richvdh merged commit c27779f into develop

richvdh deleted the rav/fix_upgrade_test branch

October 16, 2020 10:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet