Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Revert "Leave out optional keys from /sync (#9919)" #9940

Merged
merged 1 commit into from
May 6, 2021

Conversation

erikjohnston
Copy link
Member

@erikjohnston erikjohnston commented May 6, 2021

This reverts commit e9eb354 / #9919

The PR breaks Element iOS push, as its handling expects some of the keys to be there. We revert while they fix it and put out a new release.

@erikjohnston erikjohnston requested a review from a team May 6, 2021 14:00
@erikjohnston erikjohnston added the X-Release-Blocker Must be resolved before making a release label May 6, 2021
@manuroe
Copy link
Contributor

manuroe commented May 6, 2021

iOS issue: element-hq/element-ios#4309

@richvdh richvdh mentioned this pull request May 6, 2021
7 tasks
@erikjohnston erikjohnston merged commit eba431c into develop May 6, 2021
@erikjohnston erikjohnston deleted the revert-9919-develop branch May 6, 2021 14:06
@deepbluev7
Copy link
Contributor

Do I need to do anything to get that back in in a few weeks then or will that be done automatically? :3

@callahad
Copy link
Contributor

callahad commented May 6, 2021

Do I need to do anything to get that back in in a few weeks then or will that be done automatically? :3

I've filed #9941 to track re-introducing that change. The Z-Future-Maintenance label ensures we'll look at it every two weeks during release planning, and, when things are ready, we'll pull it back in :)

@deepbluev7
Copy link
Contributor

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
X-Release-Blocker Must be resolved before making a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants