Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Remove remaining is_guest argument uses from get_room_data calls #8181

Merged
merged 4 commits into from
Aug 26, 2020
Merged

Remove remaining is_guest argument uses from get_room_data calls #8181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1cbf227
Remove non-deleted parameter from test_room_displayname
anoadragon453 Aug 26, 2020
a56e660
Changelog
anoadragon453 Aug 26, 2020
373351e
lint
anoadragon453 Aug 26, 2020
990763a
Fix test_displayname as well
anoadragon453 Aug 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/8181.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove unused `is_guest` parameter from, and add safeguard to, `MessageHandler.get_room_data`.
12 changes: 2 additions & 10 deletions tests/rest/client/test_shadow_banned.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,11 +223,7 @@ def test_displayname(self):
message_handler = self.hs.get_message_handler()
event = self.get_success(
message_handler.get_room_data(
self.banned_user_id,
room_id,
"m.room.member",
self.banned_user_id,
False,
self.banned_user_id, room_id, "m.room.member", self.banned_user_id,
)
)
self.assertEqual(
Expand Down Expand Up @@ -260,11 +256,7 @@ def test_room_displayname(self):
message_handler = self.hs.get_message_handler()
event = self.get_success(
message_handler.get_room_data(
self.banned_user_id,
room_id,
"m.room.member",
self.banned_user_id,
False,
self.banned_user_id, room_id, "m.room.member", self.banned_user_id,
)
)
self.assertEqual(
Expand Down