This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Update debian systemd service to use Type=notify #8169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
suggested changes
Aug 26, 2020
changelog.d/8169.feature
Outdated
| @@ -0,0 +1 @@ | |||
| Use Type=notify in debian systemd service. | |||
There was a problem hiding this comment.
changes to the debian packaging go in the debian/changelog file, not here: please could you move this?
(there are some notes in CONTRIBUTING.rst)
richvdh
added
the
X-Awaiting-Changes
|
See the docs for an explanation.
Is this true, does synapse fire this? |
|
@clokep yes it does! |
|
In fact, Type=notify is already used by contrib/systemd/matrix-synapse.service
|
|
Done. I accidentally squashed my commits, but I hope it isn't causing
too much trouble for a one-line change.
|
richvdh
removed
the
X-Awaiting-Changes
richvdh
suggested changes
Aug 26, 2020
debian/changelog
Outdated
|
|
||
| * Use Type=notify in systemd service | ||
|
|
||
| -- Synapse Packaging team <packages@matrix.org> Wed, 26 Aug 2020 12:41:36 +0000 |
There was a problem hiding this comment.
you should probably put your own name in here.
This ensures systemctl start matrix-synapse returns only after synapse is actually started, which is very useful for automated deployments. Fixes matrix-org#5761 Signed-off-by: Dexter Chua <dec41@srcf.net>
|
Done
|
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit 'a466b6797': Reduce run-times of tests by advancing the reactor less (#7757) Update debian systemd service to use Type=notify (#8169) Remove remaining is_guest argument uses from get_room_data calls (#8181) Do not propagate typing notifications from shadow-banned users. (#8176) Remove unused parameter from, and add safeguard in, get_room_data (#8174) Add required Debian dependencies to allow docker builds on the arm platform (#8144) Allow running mypy directly. (#8175) Update the test federation client to handle streaming responses (#8130) Do not propagate profile changes of shadow-banned users into rooms. (#8157) Make SlavedIdTracker.advance have same interface as MultiWriterIDGenerator (#8171) Convert simple_select_one and simple_select_one_onecol to async (#8162)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures systemctl start matrix-synapse returns only after synapse
is actually started, which is very useful for automated deployments.
Fixes #5761