This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Change the default log config to reduce disk I/O and storage #8040
Merged
Commits on Aug 6, 2020
-
Change default log config to buffer by default.
This batches up writes to the filesystem, which is more efficient for disk I/O. This means that it can take some time for logs to get written to disk. Note that ERROR logs (and above) immediately flush the buffer. This only effects new installs, as we only write the log config if started with `--generate-config` (in the same way we do for generating signing keys).
Configuration menu - View commit details
-
Copy full SHA for 1af663d - Browse repository at this point
Copy the full SHA 1af663dView commit details -
Default to keeping last 4 days of logs.
This hopefully reduces the amount of logs kept for new servers. Keeping the last 1GB of logs is likely overkill for new servers, but equally may not be enough for busy ones. Instead, we keep the last four days worth of logs, enough so that admins can investigate any problems that happened over e.g. a long weekend.
Configuration menu - View commit details
-
Copy full SHA for 29b921e - Browse repository at this point
Copy the full SHA 29b921eView commit details -
Configuration menu - View commit details
-
Copy full SHA for ed8a183 - Browse repository at this point
Copy the full SHA ed8a183View commit details -
Configuration menu - View commit details
-
Copy full SHA for 07465f0 - Browse repository at this point
Copy the full SHA 07465f0View commit details
Commits on Aug 7, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 5936b1a - Browse repository at this point
Copy the full SHA 5936b1aView commit details -
Move setting of Filter into code.
We do this to prevent foot guns. The default config uses a MemoryFilter, but users are free to change to logging to files directly. If they do then they have to ensure to set the `filters: [context]` on the right handler, otherwise records get written with the wrong context. Instead we move the logic to happen when we generate a record, which is when we *log* rather than *handle*. (It's possible to add filters to loggers in the config, however they don't apply to descendant loggers and so they have to be manually set on *every* logger used in the code base)
Configuration menu - View commit details
-
Copy full SHA for c2fc81e - Browse repository at this point
Copy the full SHA c2fc81eView commit details -
We don't WARN too frequently, so this is fine and ensures that we log things like "STARTING" immediately.
Configuration menu - View commit details
-
Copy full SHA for 5590a73 - Browse repository at this point
Copy the full SHA 5590a73View commit details -
Revert "Move setting of Filter into code."
This reverts commit c2fc81e.
Configuration menu - View commit details
-
Copy full SHA for dd0b6f2 - Browse repository at this point
Copy the full SHA dd0b6f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7d2a9e - Browse repository at this point
Copy the full SHA e7d2a9eView commit details
Commits on Aug 10, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 62289fa - Browse repository at this point
Copy the full SHA 62289faView commit details
Commits on Aug 11, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 538efd0 - Browse repository at this point
Copy the full SHA 538efd0View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.