Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Import ABC from collections.abc #7892

Merged
merged 4 commits into from
Jul 20, 2020
Merged

Import ABC from collections.abc #7892

merged 4 commits into from
Jul 20, 2020

Conversation

tirkarthi
Copy link
Contributor

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
  • Pull request includes a sign off
  • Code style is correct (run the linters)

Fixes #7891

Signed-off-by: Karthikeyan Singaravelan <tir.karthi@gmail.com>
@clokep clokep requested a review from a team July 20, 2020 11:11
@@ -0,0 +1 @@
Import ABC from collections.abc for Python 3 compatibility.
Copy link
Member

@clokep clokep Jul 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Import ABC from collections.abc for Python 3 compatibility.
Import ABC from `collections.abc` for Python 3.10 compatibility.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is really a bugfix though. Not sure if it matters.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it since changelog was mandatory in the contributing section.

All changes, even minor ones, need a corresponding changelog / newsfragment entry. These are managed by Towncrier.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm wondering if this should be a misc change instead of a bugfix. 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would agree on it being misc instead. Renaming the file to changelog.d/7892.misc is enough :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, renamed.

changelog.d/7892.misc Outdated Show resolved Hide resolved
@clokep clokep merged commit a7b06a8 into matrix-org:develop Jul 20, 2020
@clokep
Copy link
Member

clokep commented Jul 20, 2020

Thanks for your contribution!

@tirkarthi
Copy link
Contributor Author

Thanks @clokep and @anoadragon453 :)

babolivier pushed a commit that referenced this pull request Sep 1, 2021
* commit 'de119063f': (31 commits)
  Convert room list handler to async/await. (#7912)
  Element CSS and logo in email templates (#7919)
  Lint the contrib/ directory in CI and linting scripts, add synctl to linting script (#7914)
  Remove unused code from synapse.logging.utils. (#7897)
  Fix a typo in the sample config. (#7890)
  Fix deprecation warning: import ABC from collections.abc (#7892)
  Change sample config's postgres user to synapse_user (#7889)
  Fix deprecation warning due to invalid escape sequences (#7895)
  Remove Ubuntu Eoan that is now EOL (#7888)
  Fix the trace function for async functions. (#7872)
  Add help for creating a user via docker (#7885)
  Switch to Debian:Slim from Alpine for the docker image (#7839)
  Stop using 'device_max_stream_id' (#7882)
  Fix TypeError in synapse.notifier (#7880)
  Add a default limit (of 100) to get/sync operations. (#7858)
  Change "unknown room ver" logging to warning. (#7881)
  Convert device handler to async/await (#7871)
  Convert synapse.app to async/await. (#7868)
  Convert _base, profile, and _receipts handlers to async/await (#7860)
  Add admin endpoint to get members in a room. (#7842)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing ABC directly from collections will be removed in Python 3.10
3 participants