Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Generate real events when we reject invites #7804

Merged
merged 6 commits into from
Jul 9, 2020
Merged

Generate real events when we reject invites #7804

merged 6 commits into from
Jul 9, 2020

Commits on Jul 8, 2020

  1. remove duplicated remote_reject_invite code 

    we had the same thing in two places; I don't think there's any need for this.
    @richvdh
    richvdh committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    cade6c0 View commit details
    Browse the repository at this point in the history

  2. Tweak the api for remote_reject_invite 

    Rather than passing the room id, user id, remote host, etc, just pass over the
id of the invite event we're trying to reject. It's more powerful and more
concise.
    @richvdh
    richvdh committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    86c7c18 View commit details
    Browse the repository at this point in the history

  3. Generate invite rejections locally on failure. 

    This is the core change which fixes #2181. The basic premise is that, when we
fail to reject an invite via the remote server, we can generate our own
out-of-band leave event and persist it as an outlier, so that we have something
to send to the client.

This makes the old `locally_reject_invite` impl redundant; a future commit will
remove it.
    @richvdh
    richvdh committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    fb01d27 View commit details
    Browse the repository at this point in the history

  4. Remove unused RoomMemberHandler.locally_reject_invite 

    ... and the `ReplicationEndpoint` which implemented it over federation.

Now superceded by `RoomMemberMaseterHandler._locally_reject_invite`
    @richvdh
    richvdh committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    ee95d61 View commit details
    Browse the repository at this point in the history

  5. newsfile

    @richvdh
    richvdh committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    15105b8 View commit details
    Browse the repository at this point in the history

  6. Update synapse/handlers/room_member.py 

    Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
    @richvdh @clokep
    richvdh and clokep authored Jul 8, 2020
    Configuration menu
    Copy the full SHA
    ad30dc3 View commit details
    Browse the repository at this point in the history