Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Clean up exception handling in SAML2ResponseResource #7614

Merged
merged 5 commits into from
Jun 3, 2020
Merged

Clean up exception handling in SAML2ResponseResource #7614

merged 5 commits into from
Jun 3, 2020

Commits on Jun 1, 2020

  1. Expose return_html_error 

    ... and allow it to take a Jinja2 template instead of a raw string
    @richvdh
    richvdh committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    b5de77a View commit details
    Browse the repository at this point in the history

  2. Clean up exception handling in SAML2ResponseResource 

     * use the existing code in `return_html_error` instead of re-implementing it
   (giving it a jinja2 template rather than inventing a new form of template)

 * do the exception-catching in the REST layer rather than in the handler
   layer, to make sure we catch all exceptions.
    @richvdh
    richvdh committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    3fdda31 View commit details
    Browse the repository at this point in the history

  3. changelog

    @richvdh
    richvdh committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    96f4f32 View commit details
    Browse the repository at this point in the history

  4. fix lint

    @richvdh
    richvdh committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    7efef92 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2020

  1. Update synapse/http/server.py 

    Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
    @richvdh @babolivier
    richvdh and babolivier authored Jun 2, 2020
    Configuration menu
    Copy the full SHA
    72aa58f View commit details
    Browse the repository at this point in the history