This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Stop writing to column user_id of tables profiles and user_filters
#16181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
H-Shay
commented
Aug 24, 2023
| @@ -64,64 +62,3 @@ def test_avatar_url(self) -> None: | |||
| self.assertIsNone( | |||
| self.get_success(self.store.get_profile_avatar_url(self.u_frank)) | |||
| ) | |||
|
|
|||
| def test_profiles_bg_migration(self) -> None: | |||
There was a problem hiding this comment.
The rationale for dropping these tests is that they both were testing background updates that have already run, and the changes to the code in this PR result in making it pretty impossible to run the tests in sqlite. When I added these tests I felt like they were pretty borderline useful (basically only as a proof of concept) so I think it makes sense to drop them now.
|
Removed this from the review queue since @reivilibre is taking it over and it has conflicts. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation to drop the
user_idcolumn from these tables entirely. This was originally introduced in #15787 but was reverted in #15953 because I found some places where we were still reading from the columnuser_idof the table profiles. These reads were then dropped in #15955 which was part ofv1.89.0so we should be able to stop writing to these columns now, and drop the column entirely next release cycle.