Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Always build Rust extension in release mode #14009

Merged
merged 2 commits into from
Oct 3, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions build_rust.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ def build(setup_kwargs: Dict[str, Any]) -> None:
path=cargo_toml_path,
binding=Binding.PyO3,
py_limited_api=True,
# We force always building in release mode, as we can't tell the
# difference between using `poetry` in development vs production.
debug=False,
)
setup_kwargs.setdefault("rust_extensions", []).append(extension)
setup_kwargs["zip_safe"] = False
1 change: 1 addition & 0 deletions changelog.d/14009.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix bug where Rust extension wasn't built in `release` mode when using `poetry install`.