Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Avoid generating state groups for local out-of-band leaves #12154

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Avoid generating state groups for local out-of-band leaves #12154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/12154.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Avoid generating state groups for local out-of-band leaves.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything to "clean-up" in the database from this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well in theory we might be able to go and delete the incorrectly created state groups. In practice, I'm not sure it's worthwhile.

2 changes: 1 addition & 1 deletion synapse/handlers/room_member.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1736,8 +1736,8 @@ async def _generate_local_out_of_band_leave(
txn_id=txn_id,
prev_event_ids=prev_event_ids,
auth_event_ids=auth_event_ids,
outlier=True,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my own reference, by passing this here:

  1. The event still gets it set on internal_metadata via create_new_client_event
  2. Avoids calling compute_event_context, which (I think) is what creates the state group.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct!

)
event.internal_metadata.outlier = True
event.internal_metadata.out_of_band_membership = True

result_event = await self.event_creation_handler.handle_new_client_event(
Expand Down