Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Track ongoing event fetches correctly (again) #11376

Merged
merged 15 commits into from
Nov 26, 2021
Merged

Track ongoing event fetches correctly (again) #11376

merged 15 commits into from
Nov 26, 2021

Commits on Nov 17, 2021

  1. Track ongoing event fetches correctly (again) 

    The previous fix for the ongoing event fetches counter
(8eec25a) was both insufficient and
incorrect.

When the database is unreachable, `_do_fetch` never gets run and so
`_event_fetch_ongoing` is never decremented.

The previous fix also moved the `_event_fetch_ongoing` decrement outside
of the `_event_fetch_lock` which allowed race conditions to corrupt the
counter.
    Sean Quah committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    0244ef3 View commit details
    Browse the repository at this point in the history

  2. Attempt to fix double decrement when runWithConnection fails after _d… 

    …o_fetch_txn returns
    Sean Quah committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    e88eb38 View commit details
    Browse the repository at this point in the history

  3. Reraise the exception

    Sean Quah committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    baf16f4 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2021

  1. Don't catch GeneratorExit

    Sean Quah committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    218a934 View commit details
    Browse the repository at this point in the history

  2. Refactor

    Sean Quah committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    5cb1237 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2021

  1. Rename _start_fetch_thread to _maybe_start_fetch_thread

    Sean Quah committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    3371c21 View commit details
    Browse the repository at this point in the history

  2. Rename _do_fetch and _do_fetch

    Sean Quah committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    6993247 View commit details
    Browse the repository at this point in the history

  3. Address PR feedback for events_worker.py

    Sean Quah committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    efb5574 View commit details
    Browse the repository at this point in the history

  4. Improve comments in tests

    Sean Quah committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    5976371 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2021

  1. Update synapse/storage/databases/main/events_worker.py 

    Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
    @squahtx @richvdh
    squahtx and richvdh authored Nov 25, 2021
    Configuration menu
    Copy the full SHA
    65fd879 View commit details
    Browse the repository at this point in the history

  2. Update synapse/storage/databases/main/events_worker.py 

    Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
    @squahtx @richvdh
    squahtx and richvdh authored Nov 25, 2021
    Configuration menu
    Copy the full SHA
    d1be5ce View commit details
    Browse the repository at this point in the history

  3. Update comment about idle fetch thread

    Sean Quah committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    8a0b066 View commit details
    Browse the repository at this point in the history

  4. Un-inner function _fetch_thread

    Sean Quah committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    9bb33eb View commit details
    Browse the repository at this point in the history

  5. Update docstring for _populate_events

    Sean Quah committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    a404bfd View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2021

  1. Correct typo in comment

    Sean Quah committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    37a2e94 View commit details
    Browse the repository at this point in the history