Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

add_threepid email confirmation emails link to /unstable/ namespace #9197

Open
richvdh opened this issue Jan 21, 2021 · 2 comments
Open

add_threepid email confirmation emails link to /unstable/ namespace #9197

richvdh opened this issue Jan 21, 2021 · 2 comments
Labels
A-3PID 3rd party identifiers: e.g. email, phone number O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Cleanup Things we want to get rid of, but aren't actively causing pain

Comments

@richvdh
Copy link
Member

richvdh commented Jan 21, 2021

When you add an email address to an account, you get an email which invites you to click on a link whose path is https://<server>/_matrix/client/unstable/add_threepid/email/submit_token?token=...&client_secret=....

We should not be using an unstable prefix for stable features. The correct path for this would be something under https://<server>/_synapse/client/.... Of course we'll have to support both for a while to avoid breaking the links in any emails that have already been sent.

(This was added in #6042, and probably should have been cleaned up as part of finalising matrix-org/matrix-spec-proposals#2290)

@anoadragon453 anoadragon453 added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Jan 21, 2021
@MadLittleMods MadLittleMods added the A-3PID 3rd party identifiers: e.g. email, phone number label May 16, 2022
@DMRobertson DMRobertson added S-Tolerable Minor significance, cosmetic issues, low or no impact to users. O-Occasional Affects or can be seen by some users regularly or most users rarely Z-Cleanup Things we want to get rid of, but aren't actively causing pain labels Sep 1, 2022
@DMRobertson
Copy link
Contributor

Patrick notes this and the related /_matrix/client/unstable/add_threepid/msisdn/submit_token on #8334.

I suggest we close this as superseded by that issue.

@clokep
Copy link
Member

clokep commented Sep 16, 2022

I think it would be more useful to make the results of #8334 actionable into separate issues.

I suggest we leave this open as a separate task.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-3PID 3rd party identifiers: e.g. email, phone number O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Cleanup Things we want to get rid of, but aren't actively causing pain
Projects
None yet
Development

No branches or pull requests

5 participants