Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_threepid email confirmation emails link to /unstable/ namespace #9197

Open
matrixbot opened this issue Dec 18, 2023 · 0 comments
Open

add_threepid email confirmation emails link to /unstable/ namespace #9197

matrixbot opened this issue Dec 18, 2023 · 0 comments
Labels
A-3PID Issues affecting third-party identifiers and invites O-Occasional S-Tolerable T-Task Z-Cleanup

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 18, 2023

This issue has been migrated from #9197.


When you add an email address to an account, you get an email which invites you to click on a link whose path is https://<server>/_matrix/client/unstable/add_threepid/email/submit_token?token=...&client_secret=....

We should not be using an unstable prefix for stable features. The correct path for this would be something under https://<server>/_synapse/client/.... Of course we'll have to support both for a while to avoid breaking the links in any emails that have already been sent.

(This was added in #6042, and probably should have been cleaned up as part of finalising matrix-org/matrix-spec-proposals#2290)

@matrixbot matrixbot changed the title Dummy issue add_threepid email confirmation emails link to /unstable/ namespace Dec 21, 2023
@matrixbot matrixbot added A-3PID Issues affecting third-party identifiers and invites S-Tolerable O-Occasional T-Task Z-Cleanup labels Dec 21, 2023
@matrixbot matrixbot reopened this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-3PID Issues affecting third-party identifiers and invites O-Occasional S-Tolerable T-Task Z-Cleanup
Projects
None yet
Development

No branches or pull requests

1 participant