Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Synapse supports unspecced DELETE /directory/list/appservice/<network ID>/<room ID> endpoint #14178

Open
3 tasks
DMRobertson opened this issue Oct 13, 2022 · 0 comments
Labels
A-Application-Service Related to AS support A-Spec-Compliance places where synapse does not conform to the spec O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. Z-Cleanup Things we want to get rid of, but aren't actively causing pain

Comments

@DMRobertson
Copy link
Contributor

Like #13111, but for application services.

Defined here:

async def on_DELETE(
self, request: SynapseRequest, network_id: str, room_id: str
) -> Tuple[int, JsonDict]:
return await self._edit(request, network_id, room_id, "private")

Spec is here and only defines a PUT.

Per #13111 (comment): we should

  • check the number of requests matrix.org has seen to this endpoint
  • check common appservices to see if they use it
  • assuming it's unused, rip it out
@DMRobertson DMRobertson added A-Application-Service Related to AS support A-Spec-Compliance places where synapse does not conform to the spec S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. O-Uncommon Most users are unlikely to come across this or unexpected workflow Z-Cleanup Things we want to get rid of, but aren't actively causing pain labels Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Application-Service Related to AS support A-Spec-Compliance places where synapse does not conform to the spec O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. Z-Cleanup Things we want to get rid of, but aren't actively causing pain
Projects
None yet
Development

No branches or pull requests

1 participant