Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword migration template #378

Merged
merged 4 commits into from
Aug 31, 2021
Merged

Reword migration template #378

merged 4 commits into from
Aug 31, 2021

Conversation

babolivier
Copy link
Contributor

@babolivier babolivier commented Aug 26, 2021

This PR updates the migration template by:

  • adding an Element-branded one
  • converting them to Jinja2
  • adding an HTML version to both templates
  • changing the wording from

In the past, identity services did not take capitalization into account when creating and storing Matrix IDs. We’ve now updated this behavior so anyone can find you, no matter how your email is capitalized. As part of this recent update, the duplicate Matrix ID %(mxid)s is no longer associated with this e-mail address.

to

In the past, identity services took capitalisation into account when storing email addresses. This means Alice@example.com and alice@example.com would be considered to be two different addresses, and could be associated with different Matrix accounts. We’ve now updated this behaviour so anyone can find you, no matter how your email is capitalised. As part of this recent update, we've dissociated the Matrix account {{ mxid|safe }} from this e-mail address.

@babolivier babolivier marked this pull request as ready for review August 27, 2021 14:59
@babolivier babolivier requested a review from a team August 27, 2021 15:31
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming we've checked that the emails render correctly

@babolivier
Copy link
Contributor Author

Assuming we've checked that the emails render correctly

I have, by running the script on a test db and having it send emails to mailtrap.

@babolivier babolivier merged commit 3ccd8e5 into main Aug 31, 2021
@babolivier babolivier deleted the babolivier/migration_template branch August 31, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants