Add a /versions endpoint #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clokep
commented
Dec 22, 2022
richvdh
reviewed
Dec 22, 2022
| @@ -92,6 +93,7 @@ def __init__(self, sydent: "Sydent", lookup_pepper: str) -> None: | |||
| matrix.putChild(b"identity", identity) | |||
| identity.putChild(b"api", api) | |||
| identity.putChild(b"v2", v2) | |||
| identity.putChild(b"versions", VersionsServlet()) | |||
There was a problem hiding this comment.
a test for this endpoint wouldn't go amiss...
There was a problem hiding this comment.
Adding one to the IS tester likely makes the most sense.
There was a problem hiding this comment.
clokep
force-pushed
the
clokep/versions
branch
from
f9219ec
to
31f2b4c
Compare
clokep
commented
Dec 28, 2022
|
Thanks @clokep :) Next steps: get this deployed to matrix.org and vector.im, then the clients can start to look for it in 3-6 months (closer to 3, I think). |
We'll also want to do a release. 👍 There's a PR pending for deployment though. Will ensure it gets done once more folks are back from holidays. |
|
FYI this is now deployed: $ curl https://matrix.org/_matrix/identity/versions
{"versions": ["r0.1.0", "r0.2.0", "r0.2.1", "r0.3.0", "v1.1", "v1.2", "v1.3", "v1.4", "v1.5"]} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #424.
Depends on #541.