Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix 1.1 checklist #424

Closed
2 of 4 tasks
turt2live opened this issue Oct 14, 2021 · 3 comments · Fixed by #542
Closed
2 of 4 tasks

Matrix 1.1 checklist #424

turt2live opened this issue Oct 14, 2021 · 3 comments · Fixed by #542

Comments

@turt2live
Copy link
Member

turt2live commented Oct 14, 2021

See matrix-org/synapse#11079 for more details about the new 1.1 versioning scheme for server-side stuff.

The implementation details for Sydent to support Matrix 1.1 are a whole lot simpler than pretty much any project:

  • Add /_matrix/identity/versions endpoint if not already present
  • Advertise r0.3.0 and v1.1 in that /versions endpoint
  • Do /_matrix/client/versions calls to the homeserver if necessary
  • If the homeserver supports v1.1 in its /versions, use /v3 endpoints instead of r0
@babolivier
Copy link
Contributor

babolivier commented Oct 14, 2021

  • Do /_matrix/client/versions calls to the homeserver if necessary

Could you link to the spec for this please? I'm not fully understanding how the IS is supposed to know which HS to query versions from, and for what purpose.

@turt2live
Copy link
Member Author

It's only needed if it'll be calling into the homeserver via the client-server API. If Sydent doesn't do this, the checkbox can be checked.

There's no protocol reason to do it, but that doesn't mean there's an implementation-specific reason for doing it.

@clokep
Copy link
Member

clokep commented Dec 22, 2022

  • Do /_matrix/client/versions calls to the homeserver if necessary
  • If the homeserver supports v1.1 in its /versions, use /v3 endpoints instead of r0

Neither of these seem necessary from my reading of the code. No calls to r0 endpoints are made. The only non /_matrix/identity calls which are made are to:

  • /_matrix/key/v2/server
  • /_matrix/federation/v1/openid/userid
  • /_matrix/federation/v1/3pid/onbind

Although the /_matrix/identity requests that are made all seem to be to /_matrix/identity/api/v1, not sure if that should get updated at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants