Skip to content
This repository has been archived by the owner on Nov 25, 2022. It is now read-only.

Synapse: Add step to check for unix file endings #81

Merged
merged 3 commits into from
Jul 28, 2020

Conversation

anoadragon453
Copy link
Member

To address matrix-org/synapse#7943. I'm using the python:3.6 image for consistency, but this would probably run on alpine.

@anoadragon453 anoadragon453 force-pushed the anoa/synapse_windows_file_endings branch from b21d9b1 to c38af5f Compare July 24, 2020 21:26
synapse/pipeline.yml Outdated Show resolved Hide resolved
@anoadragon453
Copy link
Member Author

Updated to use the new repo script 🙂

anoadragon453 added a commit to matrix-org/synapse that referenced this pull request Jul 28, 2020
This PRs adds a script to check for unix-line terminators in the repo. It will be used to address #7943 by adding the check to CI.

I've changed the original script slightly as proposed in matrix-org/pipelines#81 (comment)
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

part of me wonders if we should merge some of these lint steps to save spinning up lots of buildkite agents... otoh we're going to need lots of buildkite agents to run the tests so it probably doesn't make much difference.

@richvdh richvdh merged commit 6df6b76 into master Jul 28, 2020
@richvdh richvdh deleted the anoa/synapse_windows_file_endings branch July 28, 2020 11:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants