Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify how servers detect support for MSC3827 #3854

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Specify how servers detect support for MSC3827 #3854

merged 1 commit into from
Jul 26, 2022

Conversation

SimonBrandner
Copy link
Contributor

For #3827

@SimonBrandner
Specify how servers detect support for MSC3827
32f68be 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
turt2live
turt2live approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels a bit complicated for the feature at hand, but should be fine.

Realistically it can just send both without version detection.

@turt2live turt2live merged commit 0f067f1 into main Jul 26, 2022
@turt2live turt2live deleted the SimonBrandner/fix/space-explore branch July 26, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonBrandner @turt2live