Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC2414: Make reason and score parameters optional for reporting content #2414

Merged
merged 9 commits into from
Oct 7, 2020
Merged

MSC2414: Make reason and score parameters optional for reporting content #2414

Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6005c16
Merge pull request #1 from matrix-org/master
iinuwa Dec 21, 2019
692d039
Merge branch 'master' of github.com:iinuwa/matrix-doc
iinuwa Jan 14, 2020
72bc0e0
Add proposal to make reason option on content reporting
iinuwa Jan 14, 2020
2563711
Rename proposal with proper ID.
iinuwa Jan 18, 2020
bbad4c4
Add backwards-compatibility notes.
iinuwa Jun 20, 2020
9be28c5
Add proposal to remove score; reorganize
iinuwa Sep 23, 2020
07dbdab
Fix typos
iinuwa Sep 23, 2020
51b278e
Mention the endpoint
turt2live Oct 2, 2020
02512f0
Use endpoint instead of API
iinuwa Oct 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions proposals/2414-optional-content-reporting-reason.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# MSC2414: Make `reason` optional for reporting content
anoadragon453 marked this conversation as resolved.
Show resolved Hide resolved

Currently, the spec says that the `reason` parameter on the content reporting
endpoint is required, but also says that the string "may be blank." This
seems to be a contradiction.

This MSC proposes that the `required` flag for this parameter be removed, as
well as the "may be blank" clause in the description.

Note that the kicking and banning endpoints already have optional `reason`
parameters. The other endpoints mentioned in [#2367](https://github.com/matrix-org/matrix-doc/pull/2367) will also add
optional `reason` parameters, so it seems that it would be more more consistent
with the rest of the spec to make this optional as well.

## Backwards Compatibility

Since servers currently expect this field to be sent by all clients, making
this optional is a breaking change. Clients should send query the version of
the homeserver to determine whether they can safely omit this field.
iinuwa marked this conversation as resolved.
Show resolved Hide resolved