feat(ui): RoomListService::room is no longer async!
#3551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SyncRoom`. This patch updates `room_list_service::Room::new` to take a `&Client` and a `&RoomId` instead of a `SlidingSyncRoom`. The `SlidingSyncRoom` is only used in `Room::default_room_timeline_builder` and is fetched there from the `SlidingSync` instance lazily. It confines the `SlidingSyncRoom` to one single method for `Room` now.
This patch makes `RoomListService::room` synchronous. It no longer reads a `SlidingSyncRoom` from `SlidingSync`, then it not needs to be async anymore. This patch replaces the `RwLock` of `RoomListService::rooms` from `tokio::sync` to `std::sync`. The patch updates all calls to `RoomListService::room` to remove the `.await` point.
bnjbvr
approved these changes
Jun 13, 2024
This patch replaces the `RwLock` by a `Mutex` in `RoomListService::rooms` because: 1. it removes a race condition, 2. `RwLock` was used because the lock could have been taken for a long time due to the previous `.await` point. It's no longer the case, so we can blindly use a `Mutex` here.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3551 +/- ##
=======================================
Coverage 83.83% 83.83%
=======================================
Files 253 253
Lines 25843 25843
=======================================
Hits 21666 21666
Misses 4177 4177 ☔ View full report in Codecov by Sentry. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is twofold:
room_list_service::Room::newto take a&Clientand a&RoomIdinstead of aSlidingSyncRoom. TheSlidingSyncRoomis only used inRoom::default_room_timeline_builderand is fetched there from theSlidingSyncinstance lazily. It confines theSlidingSyncRoomto one single method forRoomnow.RoomListService::roomsynchronous. It no longer reads aSlidingSyncRoomfromSlidingSync, then it not needs to be async anymore. This patch replaces theRwLockofRoomListService::roomsfromtokio::synctostd::sync.SlidingSyncRoomtech debt #3079