Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

room list service: always request the room name event #3424

Merged
merged 2 commits into from
May 17, 2024
Merged

room list service: always request the room name event #3424

merged 2 commits into from
May 17, 2024

Commits on May 17, 2024

  1. sliding sync: don't store the server-computed name in place of the ra… 

    …w name event

If we want to be able to note the absence of a room name, we shouldn't
take the name returned by the server (which may be computed, and thus
always be non-null). This way, we can expose both the name contained in
the m.room.name event as well as the computed name everywhere.

A consequence of this is that the room list service must now ask for the
m.room.name event as part of the required state for every room.
    @bnjbvr
    bnjbvr committed May 17, 2024
    Configuration menu
    Copy the full SHA
    82e7e34 View commit details
    Browse the repository at this point in the history

  2. room list/notification services: don't request the room avatar since … 

    …it's always provided

It's always provided in the `avatar` response in the field, which
sliding sync's using by default, so there's no need to request the
`m.room.avatar` event too.
    @bnjbvr
    bnjbvr committed May 17, 2024
    Configuration menu
    Copy the full SHA
    85e1b1f View commit details
    Browse the repository at this point in the history