This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Revert "Check each thread for unread messages. (#9723)" #9745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9de5654.
germain-gg
added
the
T-Task
|
Seems reasonable to me. 👍 |
3 tasks
clokep
approved these changes
Dec 13, 2022
justjanne
approved these changes
Dec 13, 2022
germain-gg
added
the
X-Release-Blocker
|
@t3chguy the TS strict failure is unrelated to the changes here |
|
@gsouquet the TS strict failure is on the not required check, as per the long message from @andybalaam in Element Web Internal. The required one passed just fine! |
clokep
added a commit
to clokep/matrix-react-sdk
that referenced
this pull request
Dec 14, 2022
This re-applies the changes from 9de5654 (matrix-org#9723) which were reverted in 9668a24 (matrix-org#9745).
3 tasks
clokep
added a commit
to clokep/matrix-react-sdk
that referenced
this pull request
Dec 15, 2022
This re-applies the changes from 9de5654 (matrix-org#9723) which were reverted in 9668a24 (matrix-org#9745).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 9de5654 / #9723
The code this pull request adds is 100% valid. However, I did not consider the impact on old threads created before MSC3771. Those do not have read receipts and will trigger a notification dot.
One way to approach that will be to write client code to auto-add read receipt for those historical threads. Given the time before RC is cut, this is not the right approach and we prefer to punt this problematic for a quick follow up.
Will be needed to be re-introduced to merge #9738 and #9739 .
This pull request needs to land before #9736
Checklist
Tests written for new code (and old code if feasible)This change is marked as an internal change (Task), so will not be included in the changelog.