This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Rework ModalManager to use <dialog> #8847
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
added
the
T-Enhancement
… t3chguy/fix/22275 � Conflicts: � src/components/views/directory/NetworkDropdown.tsx
… t3chguy/fix/22275 � Conflicts: � res/css/_common.pcss � res/css/views/dialogs/_CompoundDialog.pcss � src/@types/global.d.ts � src/components/structures/MatrixChat.tsx � src/components/views/beacon/BeaconViewDialog.tsx � src/components/views/dialogs/CreateSubspaceDialog.tsx � src/components/views/messages/MBeaconBody.tsx � test/components/views/beacon/BeaconViewDialog-test.tsx
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#22275
Fixes element-hq/element-web#11513
Reading material:
https://www.scottohara.me/blog/2019/03/05/open-dialog.html
https://googlechrome.github.io/dialog-polyfill/
https://developer.mozilla.org/en-US/docs/Web/API/HTMLDialogElement/showModal
https://nolanlawson.com/2022/06/14/dialogs-and-shadow-dom-can-we-make-it-accessible/
Here's what your changelog entry will look like:
✨ Features
<dialog>HTML element for semantic dialogs/modals and native controls element-hq/element-web#22275 and Improve dialog framework element-hq/element-web#11513.